Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : add secure feature #1

Merged
merged 23 commits into from
Oct 10, 2022
Merged

feat : add secure feature #1

merged 23 commits into from
Oct 10, 2022

Conversation

YUandJIANG
Copy link
Collaborator

What type of PR is this?

feat

What this PR does / why we need it (en: English/zh: Chinese):

zh: 给 hertz 添加 secure 中间件

Which issue(s) this PR fixes:

@welkeyever
Copy link

Please use the README.md to do the introduction and usage like this: https://github.com/hertz-contrib/swagger

Skyenought
Skyenought reviewed Sep 26, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
Skyenought
Skyenought reviewed Sep 26, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
Skyenought
Skyenought approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@Skyenought Skyenought left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

li-jin-gou
li-jin-gou reviewed Sep 28, 2022
View reviewed changes
README.md Show resolved Hide resolved
li-jin-gou
li-jin-gou reviewed Sep 28, 2022
View reviewed changes
README.md Show resolved Hide resolved
li-jin-gou
li-jin-gou reviewed Sep 28, 2022
View reviewed changes
secure.go Outdated Show resolved Hide resolved
Skyenought
Skyenought approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@Skyenought Skyenought left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

li-jin-gou
li-jin-gou reviewed Oct 3, 2022
View reviewed changes
policy.go Outdated Show resolved Hide resolved
li-jin-gou
li-jin-gou reviewed Oct 3, 2022
View reviewed changes
secure.go Outdated Show resolved Hide resolved
@li-jin-gou
Copy link
Contributor

CI need to solve

li-jin-gou
li-jin-gou reviewed Oct 9, 2022
View reviewed changes
.golangci.yaml Outdated Show resolved Hide resolved
@zstone12 zstone12 self-requested a review October 9, 2022 15:29
zstone12
zstone12 reviewed Oct 9, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
zstone12
zstone12 reviewed Oct 9, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
zstone12
zstone12 reviewed Oct 9, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@zstone12
Copy link
Collaborator

LGTM

@li-jin-gou
Copy link
Contributor

CI 有问题，等待复原

@li-jin-gou
Copy link
Contributor

LGTM

@li-jin-gou li-jin-gou removed the request for review from BaiZe1998 October 10, 2022 06:53
@li-jin-gou li-jin-gou merged commit c2ee6f6 into hertz-contrib:main Oct 10, 2022
@BaiZe1998 BaiZe1998 mentioned this pull request Oct 18, 2022
Closed
3 tasks
@zstone12 zstone12 mentioned this pull request Nov 23, 2022
Closed
3 tasks
@Skyenought Skyenought mentioned this pull request May 24, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-jin-gou li-jin-gou li-jin-gou left review comments

@zstone12 zstone12 zstone12 approved these changes

@Skyenought Skyenought Skyenought approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@YUandJIANG @welkeyever @li-jin-gou @zstone12 @Skyenought