feat: support server-sent events #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: merge into main
Feat sse
Haswf
commented
Apr 11, 2023
Haswf
commented
Apr 11, 2023
Haswf
commented
Apr 11, 2023
Haswf
commented
Apr 11, 2023
Haswf
commented
Apr 11, 2023
Haswf
commented
Apr 11, 2023
li-jin-gou
approved these changes
Apr 11, 2023
Haswf
commented
Apr 11, 2023
|
需要补充一些单测，可以参考https://github.com/r3labs/sse |
|
❤️ |
li-jin-gou
reviewed
Apr 12, 2023
we don't need decoder sse is server pushing events to client
li-jin-gou
reviewed
Apr 14, 2023
li-jin-gou
reviewed
Apr 14, 2023
li-jin-gou
reviewed
Apr 14, 2023
li-jin-gou
reviewed
Apr 14, 2023
welkeyever
reviewed
Apr 14, 2023
li-jin-gou
approved these changes
Apr 15, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat: support server-sent event
What this PR does / why we need it (en: English/zh: Chinese):
en: feat: support server-sent events
zh: feat: 支持 server-sent events
Which issue(s) this PR fixes:
Fixes cloudwego/hertz#688