Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently index.d.ts exists (very helpful, thanks), but there are some diffs between implementation and that typing.
So I propose to rewrite src/*.js in TypeScript.
Internal Design Changes
Nested clausures are flatten, now
mod
is a module-scope global variable.class Common
inside of_setup
function).ReturnType
, to keep original code shape, but got TS4025 error (ref).setup
function, I add a singleton variablemod
, like a global variable insidemcl-wasm
module.setup
function dependmod
on the outside scope of them.mod
varialbe will be initialized aftermcl.init()
call, thus it doesn't leads braking changes for users.Braking Changes (maybe nothing)
For JavaScript Users
Nothing. I've confirmed:
For TypeScript Users
Types are refactored. I've confirmed no TypeScript errors in test/test-ts.ts.
TODO Before Merge