Skip to content

Commit

Permalink
Merge pull request #30 from bcoles/master
Browse files Browse the repository at this point in the history
Use HTTPS
  • Loading branch information
herval committed Oct 15, 2016
2 parents a276fce + ae74c70 commit c2106a7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions lib/yahoo-finance.rb
Expand Up @@ -165,7 +165,7 @@ def splits(symbol, options = {})

def read_quotes(symb_str, cols)
columns = "#{cols.map { |col| COLUMNS[col] }.join("")}"
conn = open("http://download.finance.yahoo.com/d/quotes.csv?s=#{URI.escape(symb_str)}&f=#{columns}")
conn = open("https://download.finance.yahoo.com/d/quotes.csv?s=#{URI.escape(symb_str)}&f=#{columns}")
CSV.parse(conn.read, headers: cols)
end

Expand All @@ -184,7 +184,7 @@ def read_historical(symbol, options)
params[:f] = options[:end_date].year
end

url = "http://ichart.finance.yahoo.com/table.csv?#{params.map{|k, v| "#{k}=#{v}"}.join("&")}"
url = "https://ichart.finance.yahoo.com/table.csv?#{params.map{|k, v| "#{k}=#{v}"}.join("&")}"
conn = open(url)
cols = if options[:period] == :dividends_only
[:dividend_pay_date, :dividend_yield]
Expand Down Expand Up @@ -212,7 +212,7 @@ def read_splits(symbol, options)
params[:f] = options[:end_date].year
end

url = "http://ichart.finance.yahoo.com/x?#{params.map{|k, v| "#{k}=#{v}"}.join("&")}"
url = "https://ichart.finance.yahoo.com/x?#{params.map{|k, v| "#{k}=#{v}"}.join("&")}"
conn = open(url)
CSV.parse(conn.read)
end
Expand Down
6 changes: 3 additions & 3 deletions lib/yahoo-finance/finance-utils.rb
Expand Up @@ -9,11 +9,11 @@ def self.included(base)
MARKETS = OpenStruct.new(
us: OpenStruct.new(
nasdaq: OpenStruct.new(
url: "http://www.nasdaq.com/screening/companies-by-name.aspx?letter=0&exchange=nasdaq&render=download"),
url: "https://www.nasdaq.com/screening/companies-by-name.aspx?letter=0&exchange=nasdaq&render=download"),
nyse: OpenStruct.new(
url: "http://www.nasdaq.com/screening/companies-by-name.aspx?letter=0&exchange=nyse&render=download"),
url: "https://www.nasdaq.com/screening/companies-by-name.aspx?letter=0&exchange=nyse&render=download"),
amex: OpenStruct.new(
url: "http://www.nasdaq.com/screening/companies-by-name.aspx?letter=0&exchange=amex&render=download")))
url: "https://www.nasdaq.com/screening/companies-by-name.aspx?letter=0&exchange=amex&render=download")))

def symbols_by_market(country, market)
symbols = []
Expand Down

0 comments on commit c2106a7

Please sign in to comment.