Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling does not work #25

Closed
xeruf opened this issue Jun 3, 2022 · 4 comments
Closed

Scaling does not work #25

xeruf opened this issue Jun 3, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@xeruf
Copy link

xeruf commented Jun 3, 2022

When I load an SVGImage and call scaleTo on it, it does not change its size :/
Using LoaderParameters does work, however!

@hervegirod hervegirod self-assigned this Jun 5, 2022
@hervegirod hervegirod added the bug Something isn't working label Jun 5, 2022
@hervegirod
Copy link
Owner

Hello,

It works in the use cases I tried. Did you get the result of the scaleTo method, or did you continue to use the initial SVGImage ? The first image is not changed, the result creates a new one.

@hervegirod
Copy link
Owner

I think that it would be better to scale the initial image however, rather than creating a new one. What do you think?

@hervegirod
Copy link
Owner

Now by default scaling an SVGImage scale the initial SVGImage rather than creating another one. Fixed in master

hervegirod pushed a commit that referenced this issue Jun 5, 2022
hervegirod pushed a commit that referenced this issue Jun 5, 2022
hervegirod pushed a commit that referenced this issue Jun 5, 2022
hervegirod pushed a commit that referenced this issue Jun 5, 2022
hervegirod pushed a commit that referenced this issue Jun 5, 2022
hervegirod pushed a commit that referenced this issue Jun 5, 2022
@xeruf
Copy link
Author

xeruf commented Jun 9, 2022

ah yes, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants