Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] After updating a web domain of another user, the UI jumps to the own web domains #3199

Closed
xeruf opened this issue Jan 12, 2023 · 5 comments · Fixed by #3208
Closed
Labels
bug Something isn't working

Comments

@xeruf
Copy link
Contributor

xeruf commented Jan 12, 2023

Describe the bug

After updating a web domain of another user, the UI jumps to the own web domains

Tell us how to replicate the bug

  1. Search for a domain of another user
  2. Select it
  3. Make some changes (e.g. enable Let's Encrypt SSL)
  4. After loading for a while, it neither stays at the domain nor at the user, it jumps to your own web domains, which is rather irritating.

Which components are affected by this bug?

Control Panel Web Interface

Hestia Control Panel Version

latest

Operating system

Debian 11

Log capture

No response

@xeruf xeruf added the bug Something isn't working label Jan 12, 2023
@ScIT-Raphael
Copy link
Member

This seems to be a very specific, local issue. I was not able to notice the same thing ever on my systems aswell as I didnt heared of it (on 35k+ active installs). As we can't reproduce the issue, its impossible for us to fix. If you could be more specific and help out debug the reason, we maybe could change something - otherwise it's probaly not fixable.

@jaapmarcus
Copy link
Member

Can confirm the bug . Issue is caused by the fact we don't change the session to the new user.

So far I can see there are 3 options:

  • Make sure we change the user sessions to the new user and disable the option to go back as admin
  • Or delete it
  • Or leave it as is...

@xeruf
Copy link
Contributor Author

xeruf commented Jan 16, 2023

I have a much simpler idea:
When editing a domain of another user, simply stay at that screen after confirmation.

@jaapmarcus
Copy link
Member

That will not work it is currently a post request

@xeruf
Copy link
Contributor Author

xeruf commented Jan 16, 2023

Make sure we change the user sessions to the new user

I think that would be best - oftentimes I search domains to find another user account, currently I then have to go back to the user overview to actually switch the session

disable the option to go back as admin

why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants