Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Count only *.tar files in backup routine (rclone) #3385

Closed
Heart1010 opened this issue Mar 24, 2023 · 0 comments · Fixed by #3393
Closed

[Feature] Count only *.tar files in backup routine (rclone) #3385

Heart1010 opened this issue Mar 24, 2023 · 0 comments · Fixed by #3393
Labels
feature New feature or request

Comments

@Heart1010
Copy link

Describe the feature or change in detail

I added rclone before 1.7x release so I already did sync my /backup folder to pcloud in my case (with rclone).
So every file inside /backup was uploaded to the cloud.

Now with v1.7 and officially rlcone support the auto backup to pcloud didn't work.
It turned out the reason was I had also all *.log files in my pcload folder and because of that the v-backup-user script has counted these log files also (and not just the *.tar files) which ended in uploading the the backup file to pcloud and immediately deletion of not just the old *.tar file but all two *.tar files.

-- SUMMARY --
2023-03-24 10:20:28 Upload With Rclone: admin.2023-03-24_10-20-28.tar
2023/03/24 10:20:29 INFO  : admin.2023-03-24_10-20-28.tar: Copied (new)
2023/03/24 10:20:29 INFO  :
Transferred:        3.145 MiB / 3.145 MiB, 100%, 0 B/s, ETA -
Transferred:            1 / 1, 100%
Elapsed time:         0.6s

Delete file: admin.2023-03-24_05-10-37.tar
Delete file: admin.2023-03-24_10-20-28.tar
2023-03-24 10:20:30 Rotated: 2023-03-24_05-10-37
2023-03-24 10:20:30 Local: /backup/admin.2023-03-24_10-20-28.tar
2023-03-24 10:20:30 Size: 4 MB
2023-03-24 10:20:30 Runtime: 1 minute

So Jaap and I discussed if it's not a good idea to only count *.tar files (see if [ "$backups_count" -ge "$BACKUPS" ]; ....)

Would you like to sponsor this feature to have it implemented?

No

@Heart1010 Heart1010 added the feature New feature or request label Mar 24, 2023
@jaapmarcus jaapmarcus linked a pull request Mar 25, 2023 that will close this issue
ScIT-Raphael pushed a commit that referenced this issue Mar 25, 2023
* Improve log message to what endpoint is used

* Only check .tar files

* Use $HOST:$BPATH instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant