Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Nginx 1.25.1+ Listen ... http2" directive is deprecated #3684

Closed
jaapmarcus opened this issue Jun 13, 2023 · 11 comments · Fixed by #3704
Closed

[Bug] Nginx 1.25.1+ Listen ... http2" directive is deprecated #3684

jaapmarcus opened this issue Jun 13, 2023 · 11 comments · Fixed by #3704
Assignees
Labels
bug Something isn't working web Issues related to web components

Comments

@jaapmarcus
Copy link
Member

Describe the bug

Update Nginx to 1.25.1 and restart server

[warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead

Tell us how to replicate the bug

Update Nginx to 1.25.1 and restart server

[warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead

Changes required is to replace:

    listen      5.9.186.106:443 ssl http2;

With

    listen      ip:443 ssl;
    http2 on;

We should probally convert all the templates and sed them to the 1.25.0 pre format if nginx 1.25.0 or earlier is detected

Which components are affected by this bug?

(Backend) Web Server (Nginx, Apache2)

Hestia Control Panel Version

1.x.x

Operating system

N/A

Log capture

Update Nginx to 1.25.1 and restart server

[warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead
@jaapmarcus jaapmarcus added the bug Something isn't working label Jun 13, 2023
@jaapmarcus jaapmarcus self-assigned this Jun 13, 2023
@jaapmarcus jaapmarcus added the web Issues related to web components label Jun 13, 2023
@jaapmarcus
Copy link
Member Author

It looks like only "Webdomains" are affected

https://github.com/hestiacp/hestiacp/blob/main/src/deb/nginx/nginx.conf

@myrevery
Copy link
Contributor

This "issue" is not urgent yet.

NGINX usually removes obsolete directives after 5 major mainline version.

Suggested action: Send reminder to existing users, urging them to upgrade NGINX ASAP.

Reference: NGINX's code

Also, what's the ETA of Hestia 1.8.0?

There are a few more features want to add, but I've been too busy lately...

@jaapmarcus
Copy link
Member Author

Also, what's the ETA of Hestia 1.8.0?

There are a few more features want to add, but I've been too busy lately...

No set time yet. How ever if Bookworm goes fine probably soon... How ever we probably want to wait for Mysql 8 support unless it take ages...

I don't mind my self to have 1.9 following quick...

I agree that is has no priority yet how ever

@chriscapisce
Copy link
Contributor

chriscapisce commented Jun 15, 2023

I got the same warning both for domains and webmail.

nginx: [warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead in /etc/nginx/conf.d/XX.XX.XXX.XX.conf:16

nginx: [warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead in /etc/nginx/conf.d/domains/clientdomain.nl.ssl.conf:8

nginx: [warn] the "listen ... http2" directive is deprecated, use the "http2" directive instead in /etc/nginx/conf.d/domains/webmail.clientdomain.nl.ssl.conf:2

@jaapmarcus
Copy link
Member Author

All Nginx configs with ssl enabled are effected ...

@jaapmarcus jaapmarcus changed the title [Bug] Nginx 1.25.1 [Bug] Nginx 1.25.1 Listen ... http2" directive is deprecated Jun 15, 2023
@jaapmarcus jaapmarcus changed the title [Bug] Nginx 1.25.1 Listen ... http2" directive is deprecated [Bug] Nginx 1.25.1+ Listen ... http2" directive is deprecated Jun 15, 2023
@jaapmarcus jaapmarcus pinned this issue Jun 15, 2023
@myrevery
Copy link
Contributor

A hotfix for this issue is on the way...

ETA is tomorrow (PDT).

@jaapmarcus
Copy link
Member Author

A hotfix for this issue is on the way...

ETA is tomorrow (PDT).

#3697

Should work fine

@TheRickDeckard
Copy link

Hi, with HestiaCP v1.7.8, nginx only, after generating Let's Encrypt for a just added user and domain (ssl for main domain, mail and webmail), nginx crash and cannot be restarted.

Deleting latest user show an error, the solution was manually removing related nginx conf files from /etc/nginx/conf.d/domains/ and after removing this user in HestiaCP.
Now the previous users are working but i can't add a new one.

Really need a fix asap. thanks.

@jaapmarcus
Copy link
Member Author

This error doesn't prevent the system from working

@TheRickDeckard
Copy link

TheRickDeckard commented Jul 8, 2023

This error doesn't prevent the system from working

Thanks for your reply but with nginx only on server,
Nginx service crash and cannot be restart, the only fix find was removed latest just added user.

@jaapmarcus
Copy link
Member Author

The warning generated should not matter. I don't know what the error message was...

@jaapmarcus jaapmarcus unpinned this issue Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working web Issues related to web components
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants