-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow customizing HestiaCP with js/php #2747
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make a folder where everything that loads init.js will load additional .js/.php files, allowing people to customize their HestiaCP control panels. I must admit, I have not studied the HestiaCP plugin system, and if it turns out that the plugin system is superior to this folder, please tell me about it :) I couldn't really find documentation on the plugin system
Removed code tags as they break drone Last code example
|
i think the only thing htmlentities did was to encode "+" characters, which isn't required when using RAWurlencode, and im not even sure it was actually required with normal urlencode.
ScIT-Raphael
approved these changes
Aug 30, 2022
jaapmarcus
approved these changes
Aug 30, 2022
Ideally we should work to a system where we can use plugins and so on |
jaapmarcus
pushed a commit
that referenced
this pull request
Aug 30, 2022
* allow customizing HestiaCP with js/php make a folder where everything that loads init.js will load additional .js/.php files, allowing people to customize their HestiaCP control panels. I must admit, I have not studied the HestiaCP plugin system, and if it turns out that the plugin system is superior to this folder, please tell me about it :) I couldn't really find documentation on the plugin system * code-breaking typos * make CI run again (CI is bugging out) * simplify code i think the only thing htmlentities did was to encode "+" characters, which isn't required when using RAWurlencode, and im not even sure it was actually required with normal urlencode. * DirectoryIterator isn't static-callable ick * make CI run again (i think it's bugging out?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make a folder where everything that loads init.js will load additional .js/.php files, allowing people to customize their HestiaCP control panels.
I must admit, I have not studied the HestiaCP plugin system, and if it turns out that the plugin system is superior to this folder, please tell me about it :) I couldn't really find documentation on the plugin system
There's also the question about whether or not we actually want to make it easy for HestiaCP users to customize the panel. Personally I would appreciate it.
For example, recently on the Discord support channel, someone asked
and the answer was basically
with the keyword being *will reverted at each upgrade*
if some version of this gets merged, the answer could instead be:
There is no official support to do it, but you can make a web/js/custom_scripts/only_wordpress.js