Modernise favicon #2873
Merged
Modernise favicon #2873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `logo.png` and `logo.svg` seem to be slightly different.
|
It's interesting to note that
I assume I've updated |
jaapmarcus
approved these changes
Aug 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current problem
The Hestia favicon is all fuzzy on HiDPI screens.
Proposed solution
Replace outdated ICO favicon solution with modern SVG/PNG solution.
Now the favicon that loads is actually the main logo.svg which has been optimised. The fallback favicon.png for older browsers is the correct size (32x32px) for HiDPI screens.
Screenshots
Before:
After (SVG)
After (PNG fallback)
