Extract normalize.css dependency #2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also removes |
This isn't doing anything, it's just duplicating the `rel` attribute producing invalid HTML. See appropriate usage: https://3perf.com/blog/link-rels/
ScIT-Raphael
approved these changes
Aug 28, 2022
jaapmarcus
approved these changes
Aug 28, 2022
jaapmarcus
added a commit
that referenced
this pull request
Aug 28, 2022
* Commit whitespace changes * Extract normalize.css dependency * Remove repeated normalize.css styles * More consistent attribute order * Tidy * Remove invalid rel="preload" from stylesheets This isn't doing anything, it's just duplicating the `rel` attribute producing invalid HTML. See appropriate usage: https://3perf.com/blog/link-rels/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current problem
Within default.css I see a pasted copy of a very old version of normalize.css. The pasted copy includes styles for IE 6/7 so is one of the first versions of this CSS reset.
Having this dependency pasted in the custom CSS is not ideal, we should be able to update it like other CSS dependencies.
Proposed solution
I have used a slightly newer version 3.0.3 of normalize.css with no IE 6/7 styles, but it's very similar and won't impact styles.
There were a couple modifications to the original pasted normalize.css which have been retained.
Screenshots
No visual change, but feel free to test!