Fix casing inconsistency of $TAB on login page #2883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was made lowercase in #926, not sure why.
jaapmarcus
approved these changes
Aug 29, 2022
jaapmarcus
pushed a commit
that referenced
this pull request
Aug 30, 2022
This was made lowercase in #926, not sure why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current problem
Now that $TAB is more visible in page <title> since #2871, I notice how the login page has inconsistent casing with all other pages. This happened in #926 but I'm not sure why.
Proposed solution
Change it back to uppercase so it matches the other pages. If the casing is changed we should do it for all pages at once.
Screenshots
Before:
After:
