-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix v-add-backup-host for sftp servers with different login prompt #2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… prompt On FreeBSD hosted sftp server, the password prompt looks something like this: "Password for: user@host:". This case was not handled so far.
jaapmarcus
requested changes
Oct 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also adjust
/func/backup.sh then
Good catch. This is now done @jaapmarcus |
jaapmarcus
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have FreeBSD server running...
jaapmarcus
added a commit
that referenced
this pull request
Oct 5, 2022
…2950) * Fix v-add-backup-host for sftp server that outputs different password prompt On FreeBSD hosted sftp server, the password prompt looks something like this: "Password for: user@host:". This case was not handled so far. * Fix sftp backup procedure for servers with different login prompt
Merged
jaapmarcus
added a commit
that referenced
this pull request
Oct 5, 2022
* Fix issue with incorrect merge * Fix bug v-change-web-domain-name * Fix Quick installer issues (#2921) * Some rare cases version might be empty * Remove debug info * If admin is not created status is not set * Return correct status code * Fix docuwiki installer Install dir got changed due to new version * Update to 2022-07-31a See CVE-2022-3123 * Update opencart * Use correct folder * Update prestashop * Fix few small bugs related to host ssl (#2922) * Fix issue when ssl for domain allready exists It seems USER_DATA was not properly loaded root@dev:/usr/local/hestia/ssl# v-add-letsencrypt-host cat: /usr/local/hestia/data/users//user.conf: No such file or directory grep: /usr/local/hestia/data/users//web.conf: No such file or directory grep: /usr/local/hestia/data/users//web.conf: No such file or directory grep: /usr/local/hestia/data/users//web.conf: No such file or directory Error: nginx restart failed Error: nginx restart failed Error: Let's Encrypt SSL creation failed * No need to restart web / proxy service Only Hestia, mail and ftp get updated * Fix bug for modphp setups * Merge pull request #2924 from jaapmarcus/fix/allow-more-chars-for-name is_name_format_valid is only used for the name * Merge pull request #2925 from hestiacp/jaapmarcus-patch-1 When restart is not set it should reload instead restart * 2788 [Bug] Quick install Wordpress other languages then EN (#2818) * Update changelog [CI SKIP] [CI SKIP] * updated jquery to v3.6.1 (#2932) * Update changelog * Fix #2943 for release branch * Update changelog * Update version * Quick installer: Use the MediaWiki 1.38.4 (#2948) See https://lists.wikimedia.org/hyperkitty/list/mediawiki-announce@lists.wikimedia.org/thread/DMQKMFSH4K7KLBXWZTDBGI2PWLLHJHJZ/ * Add support for Kurdish Sorani @qezwan * php version bump * Add check if email is valid (#2944) * Allow the use of (#2951) v-add-remote-dns-host dev.xxxx.xxx 8083 'xxxxxxxx' '' '' "newuser" * Add support for Kurdish Sorani (#2945) @qezwan * Fix v-add-backup-host for sftp servers with different login prompt (#2950) * Fix v-add-backup-host for sftp server that outputs different password prompt On FreeBSD hosted sftp server, the password prompt looks something like this: "Password for: user@host:". This case was not handled so far. * Fix sftp backup procedure for servers with different login prompt * Update changelog * Small changes Changelog [skip_ci] * Update versions Co-authored-by: Raphael <rs@scit.ch> Co-authored-by: Alber Khan <39749258+4183r@users.noreply.github.com> Co-authored-by: Zoran Dori <zorandori4444@gmail.com> Co-authored-by: Ice Lake <30789544+istiak101@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a FreeBSD hosted sftp server, the password prompt looks different. Example:
Password for user@host:
This pull-request fixes the issue.
/etc/ssh/sshd_config