Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cron pages for mobile #3166

Merged
merged 1 commit into from
Dec 27, 2022
Merged

Refactor cron pages for mobile #3166

merged 1 commit into from
Dec 27, 2022

Conversation

AlecRust
Copy link
Contributor

@AlecRust AlecRust commented Dec 24, 2022

All fields are now in one form, with the "generate" fields detached from submit using "form=""".

Also rewrites the JS for these forms to remove jQuery and jQuery UI usage, namely effect() which has been removed from the custom jQuery UI build. Any manual testing of this would be appreciated.

No visual change on desktop.

screenshot

@jaapmarcus
Copy link
Member

jaapmarcus commented Dec 24, 2022

209443789-716baf98-0dd0-4b88-9eca-36ac4120fd81
209443792-44da0c05-c133-45ce-a2d3-3402be87f2a4
209443797-1f8ba4d1-d72c-450d-a2d6-946880dca4c3

@jaapmarcus
Copy link
Member

Not related to this PR

Also "Expand" / "Collapse" main menu press doesn't hide the "Menu" open window on the Server, Filemanger and Logout

Copy link
Member

@jaapmarcus jaapmarcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@AlecRust AlecRust force-pushed the refactor-cron branch 2 times, most recently from 25294c2 to 975a22d Compare December 26, 2022 11:02
@AlecRust AlecRust changed the title Refactor cron page layout Refactor cron pages for mobile Dec 26, 2022
@AlecRust
Copy link
Contributor Author

See comments

Thanks, I've fixed the worst of the issues in your screenshots.

image

@jaapmarcus jaapmarcus self-requested a review December 26, 2022 11:06
@jaapmarcus
Copy link
Member

5 times better...

@AlecRust AlecRust force-pushed the refactor-cron branch 3 times, most recently from 0853e1b to 7ef64da Compare December 26, 2022 13:39
web/js/pages/add_cron.js Outdated Show resolved Hide resolved
web/js/pages/edit_cron.js Outdated Show resolved Hide resolved
@AlecRust AlecRust merged commit 34bd8d6 into main Dec 27, 2022
@AlecRust AlecRust deleted the refactor-cron branch December 27, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants