Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build JS/CSS Theme on release #3525

Merged
merged 14 commits into from
May 2, 2023
Merged

Build JS/CSS Theme on release #3525

merged 14 commits into from
May 2, 2023

Conversation

jaapmarcus
Copy link
Member

As we now build CSS and JS with postcss and esbuild a few merge conflicts where created.

This PR will ignore both /web/css/themes and /web/js/dist/ folder

And build them on release

Copy link
Contributor

@AlecRust AlecRust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should probably also git rm -r web/js/dist or whatever, and same for web/css/themes

.drone.yml Outdated Show resolved Hide resolved
remove the bats tests for now
Also upgrade yarn to 3.5.1
.gitignore Outdated Show resolved Hide resolved
.drone.yml Outdated Show resolved Hide resolved
jaapmarcus and others added 4 commits May 2, 2023 16:35
@jaapmarcus jaapmarcus marked this pull request as ready for review May 2, 2023 15:20
@jaapmarcus jaapmarcus requested a review from AlecRust May 2, 2023 17:10
Copy link
Contributor

@AlecRust AlecRust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jaapmarcus jaapmarcus merged commit 0e56a46 into main May 2, 2023
7 checks passed
@jaapmarcus jaapmarcus deleted the remove-dist-files branch May 2, 2023 17:53
@jaapmarcus jaapmarcus mentioned this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants