Fix: DNS cluster expected return code instead of string #3706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes: #3707 |
ScIT-Raphael
requested changes
Jun 21, 2023
| @@ -50,6 +51,7 @@ function exit_code_to_http_code(int $exit_code, int $default = 400): int { | |||
| case E_UNSUSPENDED: | |||
| case E_FORBIDEN: | |||
| case E_FORBIDDEN: | |||
| case E_API_DISABLED: | |||
| return 401; | |||
There was a problem hiding this comment.
alignment of return should be checked.
There was a problem hiding this comment.
Looks fine and consistent to me...
ScIT-Raphael
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNS cluster syncing / set up requires always an numeric code in return.
hestiacp/func/remote.sh
Line 50 in 8c26daa
In the past by default the text was shown if an error code was generated if the users tries to connect with an incorrect password/key or ip is not allowed