Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phpBB Nginx template #3731

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Add phpBB Nginx template #3731

merged 2 commits into from
Jun 30, 2023

Conversation

xchwarze
Copy link
Contributor

@xchwarze xchwarze commented Jun 30, 2023

Based on official example: https://github.com/phpbb/phpbb/blob/master/phpBB/docs/nginx.sample.conf
Tested with last versions of php, hestiacp and phpbb.
It has added the code of TLS 1.3 0-RTT anti-replay

Copy link
Member

@jaapmarcus jaapmarcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also in install/deb/templates/web/nginx/php-fpm/

Folder

@xchwarze
Copy link
Contributor Author

@jaapmarcus copied

@jaapmarcus jaapmarcus merged commit e5b8cfb into hestiacp:main Jun 30, 2023
6 checks passed
fastcgi_split_path_info ^(.+\.php)(/.*)$;
fastcgi_param PATH_INFO $fastcgi_path_info;
fastcgi_param SCRIPT_FILENAME $realpath_root$fastcgi_script_name;
#fastcgi_param HTTP_EARLY_DATA $rfc_early_data if_not_empty;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xchwarze Hi, forgot to uncomment?

fastcgi_split_path_info ^(.+\.php)(/.*)$;
fastcgi_param PATH_INFO $fastcgi_path_info;
fastcgi_param SCRIPT_FILENAME $realpath_root$fastcgi_script_name;
#fastcgi_param HTTP_EARLY_DATA $rfc_early_data if_not_empty;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's true, when I polished the content of my test server I forgot to delete them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update when you have time, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants