Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add v-dump-site #3808

Merged
1 commit merged into from Jul 21, 2023
Merged

[Feature] Add v-dump-site #3808

1 commit merged into from Jul 21, 2023

Conversation

hudokkow
Copy link
Contributor

Please do not merge before we discuss.

Similar functionality to #3644 but for the site files.

A couple of questions regarding your preferences:

  • archive type: zip, tar, tar.gz? Which one should I use? Zip is more common and I'm guessing a lot of folks don't use *nix every day.
  • By default, do you want to archive everything under /home/$user/web/$domain/ or is /home/$user/web/$domain/public_html/ ok? I kinda like the latter.

Please decide. I'll accommodate the changes, if any, and force push to update this PR.

Have a great one!

@jaapmarcus
Copy link
Member

I wonder what the advantage over creating a backup or just use sftp to download It.

v-dump-database as phpmyadmin sucks at exporting larger databases.. And a lot of times I experinced issues with it as it was slow as f***.

I would prefer see a function to clone a website to a new domain in Hestia as for example staging ...

@hudokkow
Copy link
Contributor Author

Ease of use and quick access. Together with a database dump you have pretty much everything you need to move from staging to prod server, something I do quite often. Also why I would prefer to only dump public_html. Clients can give their staff the files and off they go.

BTW, clone is coming.

Just need a few (lot?) more days to test and possibly rewrite code to reuse already present code and functions in Hestia's repo. Or leave the rewriting for later since I'm only starting to get my feet wet in Hestia's codebase. :-)

@jaapmarcus
Copy link
Member

Ease of use and quick access. Together with a database dump you have pretty much everything you need to move from staging to prod server, something I do quite often. Also why I would prefer to only dump public_html. Clients can give their staff the files and off they go.

BTW, clone is coming.

Just need a few (lot?) more days to test and possibly rewrite code to reuse already present code and functions in Hestia's repo. Or leave the rewriting for later since I'm only starting to get my feet wet in Hestia's codebase. :-)

Depending on the software used they might also use folder in /home/user/web/domain/dir

@hudokkow
Copy link
Contributor Author

That's decided. /home/$user/web/$domain/ it is.

@johnnyq
Copy link

johnnyq commented Jul 20, 2023

@hudokkow neat a feature I didn't know I needed until now. It would be awesome to also create another function to download mail domain and individual mailboxes. For Quick Archival Purposes

@hudokkow
Copy link
Contributor Author

Out of scope for me. At least for now. I'm focusing on stuff I need every day.

@johnnyq
Copy link

johnnyq commented Jul 20, 2023

Gotchya that makes sense

@hudokkow hudokkow changed the title [RFC/ Do not merge yet][Feature] Add v-dump-site [Feature] Add v-dump-site Jul 20, 2023
@jaapmarcus
Copy link
Member

I assume it is ready for review?

@hudokkow hudokkow marked this pull request as ready for review July 20, 2023 20:09
@hudokkow
Copy link
Contributor Author

Yes, thank you.

@ghost ghost self-requested a review July 20, 2023 21:31
@ghost ghost merged commit 0de4bf7 into hestiacp:main Jul 21, 2023
6 checks passed
@hudokkow hudokkow deleted the dump_site branch July 21, 2023 11:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants