Delay submit in Desktop Safari #4137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure spinner is shown.
jaapmarcus
approved these changes
Nov 8, 2023
jaapmarcus
pushed a commit
that referenced
this pull request
Nov 8, 2023
To ensure spinner is shown.
|
Ugh. Is this issue resulting in a double submit when adding a domain using the keyboard on Safari? I'm getting a: Error: Web domain test5.dev.pw exists Only when using the keyboard Add Web Domain -> [type your web domain] -> press enter. Doesn't Other, non-Safari, browsers are okay. |
|
Also occurs on Safari for iOS 17.x, using the “return” virtual keyboard key; iPad. |
|
See #4206 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait half a second on Desktop Safari, ensure spinner is consistently shown.
supersedes #4062