New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added watcher for staleness #2

Merged

heston merged 3 commits into master from add-watcher

Mar 19, 2018

Owner

heston commented Mar 18, 2018

This adds a thread-based watcher to periodically check for data staleness, and restart the SSE connection if needed.


          Added watcher for staleness

0b53fd7

coveralls commented Mar 18, 2018

Pull Request Test Coverage Report for Build 24

58 of 60 (96.67%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 98.851%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
firebasedata/watcher.py	53	55	96.36%

Totals
Change from base Build 21:	-0.7%
Covered Lines:	258
Relevant Lines:	261

💛 - Coveralls

1 similar comment

coveralls commented Mar 18, 2018

Pull Request Test Coverage Report for Build 24

58 of 60 (96.67%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 98.851%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
firebasedata/watcher.py	53	55	96.36%

Totals
Change from base Build 21:	-0.7%
Covered Lines:	258
Relevant Lines:	261

💛 - Coveralls

coveralls commented Mar 18, 2018 •

edited

Pull Request Test Coverage Report for Build 28

60 of 60 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 99.617%

Totals
Change from base Build 21:	0.1%
Covered Lines:	260
Relevant Lines:	261

💛 - Coveralls

heston added 2 commits

March 19, 2018 08:13


          Added missing test

a41a968


          Version bump

ebf63d5

heston merged commit a7fcc9e into master

heston deleted the add-watcher branch

March 19, 2018 16:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment