Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize paths when interacting with signals #6

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Conversation

heston
Copy link
Owner

@heston heston commented Nov 26, 2018

Signal names are always paths. However, when connecting to a signal, the same path may be specified in multiple ways. For example, /foo/bar/ is the same as foo/bar for all intents and purposes. This change normalizes path names when retrieving Signals, to account for such differences.

@heston heston merged commit a82e094 into master Nov 26, 2018
@heston heston deleted the normalize-signals branch November 26, 2018 23:01
@coveralls
Copy link

Pull Request Test Coverage Report for Build 47

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 45: 0.0%
Covered Lines: 267
Relevant Lines: 267

💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 47

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 45: 0.0%
Covered Lines: 267
Relevant Lines: 267

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 47

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 45: 0.0%
Covered Lines: 267
Relevant Lines: 267

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants