Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @metelkin,
I reviewed the Heta Complier paper and tested it out with MRGSolve. It worked very well and it required no changes after compiling. I was also able to compile into the other supported formats with a simple model and they all were built successfully. I didn't have the ability to test everything but I reviewed all of the files and they all looked as expected.
I'm no longer directly in the QSP field but I do remember interfacing between different models was a big challenge for us that went unsolved as far as I'm aware. Heta looks to be a great solution and would fit into most modern model development processes, which is something I haven't seen much of in the QSP field. Overall I think a big step forward.
Here are a few changes I would make to the paper to improve clarity. Feel free to toss out if you disagree.
Thanks for all your effort!
Eli