Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS Review: Paper updates #9

Merged
merged 1 commit into from Oct 29, 2021
Merged

JOSS Review: Paper updates #9

merged 1 commit into from Oct 29, 2021

Conversation

elimillera
Copy link

Hello @metelkin,

I reviewed the Heta Complier paper and tested it out with MRGSolve. It worked very well and it required no changes after compiling. I was also able to compile into the other supported formats with a simple model and they all were built successfully. I didn't have the ability to test everything but I reviewed all of the files and they all looked as expected.

I'm no longer directly in the QSP field but I do remember interfacing between different models was a big challenge for us that went unsolved as far as I'm aware. Heta looks to be a great solution and would fit into most modern model development processes, which is something I haven't seen much of in the QSP field. Overall I think a big step forward.

Here are a few changes I would make to the paper to improve clarity. Feel free to toss out if you disagree.

Thanks for all your effort!
Eli

@metelkin
Copy link
Contributor

Hello @elimillera,
Thank you for your review and high opinion.
All the changes seem reasonable and improve the quality of the text.

@metelkin metelkin merged commit e892c31 into hetalang:paper Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants