Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback pour bouton partager #7

Closed
GitSquared opened this issue Apr 27, 2020 · 2 comments · Fixed by #19
Closed

Fallback pour bouton partager #7

GitSquared opened this issue Apr 27, 2020 · 2 comments · Fixed by #19
Assignees
@Satwa
Labels
enhancement New feature or request low-priority UI
Milestone
Back-office 1.0

Comments

@GitSquared
Copy link
Contributor

Sur les navigateurs qui ne supportent pas Navigator.share(), il n'y a pas de fallback pour partager articles ou auteurs.
@Satwa Satwa self-assigned this Apr 30, 2020
@GitSquared
Copy link
Contributor Author

Cf:

heticiens.news/pages/author/[name].js

Line 9 in 27f97e3

function share(title) {

heticiens.news/pages/articles/[title].js

Line 26 in 27f97e3

function share(title) {

Ping @Satwa

@GitSquared GitSquared added enhancement New feature or request low-priority UI labels May 1, 2020
Satwa added a commit that referenced this issue May 1, 2020
@Satwa
feat(ui): add a fallback modal to native sharing feature
a5fff93 
close #7
@Satwa Satwa closed this as completed May 1, 2020
@Satwa Satwa mentioned this issue May 1, 2020
Merged
@GitSquared
Copy link
Contributor Author

On laisse ouvert, ça va être fermé automatiquement quand la PR est merge 👍

@GitSquared GitSquared reopened this May 1, 2020
@GitSquared GitSquared added this to the Back-office 1.0 milestone May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Satwa Satwa

Labels
enhancement New feature or request low-priority UI
Projects
None yet
Milestone
Back-office 1.0
Development

Successfully merging a pull request may close this issue.

feat(ui): add a fallback modal to native sharing feature hetic-newsroom/heticiens.news
2 participants
@Satwa @GitSquared