fix(floating-ip): list command only returns first 50 entries #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the FloatingIPClient List was used instead of AllWithOpts, which resulted in "list" only returning the first 50 entries.
apricote
approved these changes
Oct 19, 2023
phm07
pushed a commit
that referenced
this pull request
Oct 25, 2023
🤖 I have created a release *beep* *boop* --- ## [1.39.0](v1.38.3...v1.39.0) (2023-10-25) ### Features * add --enable-protection flag to "create" commands ([#567](#567)) ([e313e69](e313e69)) * add "all list" command to list all resources in the project ([6d3b064](6d3b064)) * **iso:** allow to filter list by type (public, private) ([#573](#573)) ([140cbc3](140cbc3)) * **primary-ip:** enable/disable-protection accept levels as arguments ([#564](#564)) ([b11e223](b11e223)) * **server:** add --enable-backup flag to "create" command ([#568](#568)) ([15adee0](15adee0)) * **server:** add --wait flag to "shutdown" command ([#569](#569)) ([3ce048c](3ce048c)) ### Bug Fixes * **floating-ip:** list command only returns first 50 entries ([#574](#574)) ([f3fa881](f3fa881)) * **image:** list does not parse "type" flag correctly ([#578](#578)) ([9a0487a](9a0487a)) * list outputs null instead of empty array when listing in JSON ([#579](#579)) ([93bed7e](93bed7e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
phm07
added a commit
that referenced
this pull request
Oct 31, 2023
The list commands for datacenters, load balancer types, locations and server types used List() instead of AllWithOpts() to fetch resources. List() only returns a single page of resources at a time (50 entries in this case), while AllWithOpts() returns all of them. This does not make a difference at the moment, but could be a problem in the future. Similar to #574
phm07
added a commit
that referenced
this pull request
Oct 31, 2023
The list commands for datacenters, load balancer types, locations and server types uses ``List()`` instead of ``AllWithOpts()`` to fetch resources. ``List()`` only returns a single page of resources at a time (50 entries in this case), while ``AllWithOpts()`` returns all of them. This does not make a difference at the moment, but could be a problem in the future. Similar to #574
phm07
added a commit
that referenced
this pull request
Oct 31, 2023
The list commands for datacenters, load balancer types, locations and server types uses ``List()`` instead of ``AllWithOpts()`` to fetch resources. ``List()`` only returns a single page of resources at a time (50 entries in this case), while ``AllWithOpts()`` returns all of them. This does not make a difference at the moment, but could be a problem in the future. Similar to #574
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the FloatingIPClient List was used instead of AllWithOpts, which resulted in "list" only returning the first 50 entries. (Same as #415)