Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wording when metrics are not yet available #639

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

jooola
Copy link
Member

@jooola jooola commented Dec 14, 2023

The wording was incorrect.

@jooola jooola requested a review from a team as a code owner December 14, 2023 16:22
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (50fe4ca) 46.27% compared to head (02ccfe8) 46.27%.
Report is 1 commits behind head on main.

Files Patch % Lines
internal/cmd/loadbalancer/metrics.go 0.00% 1 Missing ⚠️
internal/cmd/server/metrics.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #639   +/-   ##
=======================================
  Coverage   46.27%   46.27%           
=======================================
  Files         171      171           
  Lines        7456     7456           
=======================================
  Hits         3450     3450           
  Misses       3583     3583           
  Partials      423      423           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola merged commit 9298c46 into hetznercloud:main Dec 15, 2023
3 checks passed
@jooola jooola deleted the fix-wording branch December 19, 2023 09:54
jooola pushed a commit that referenced this pull request Dec 21, 2023
🤖 I have created a release *beep* *boop*
---


##
[1.41.1](v1.41.0...v1.41.1)
(2023-12-21)


### Bug Fixes

* allow multiple --type flags for metrics commands
([#649](#649))
([69346f7](69346f7)),
closes [#642](#642)
* integer fields are displayed as floats when using create with o=yaml
([#651](#651))
([2d42fcd](2d42fcd))
* integer fields are displayed as floats when using describe with
-o=yaml ([#650](#650))
([ee4c51e](ee4c51e)),
closes [#638](#638)
* wording when metrics are not yet available
([#639](#639))
([9298c46](9298c46))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants