Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: integer fields are displayed as floats when using describe with -o=yaml #650

Merged
merged 2 commits into from
Dec 19, 2023
Merged

fix: integer fields are displayed as floats when using describe with -o=yaml #650

merged 2 commits into from
Dec 19, 2023

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Dec 19, 2023

Closes #638

@phm07 phm07 added the bug label Dec 19, 2023
@phm07 phm07 self-assigned this Dec 19, 2023
@phm07 phm07 requested a review from a team as a code owner December 19, 2023 09:44
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2023 •
edited

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (69346f7) 46.23% compared to head (827819c) 45.94%.

Files Patch % Lines
internal/cmd/certificate/describe.go 50.00% 2 Missing and 1 partial ⚠️
internal/cmd/datacenter/describe.go 50.00% 2 Missing and 1 partial ⚠️
internal/cmd/firewall/describe.go 50.00% 2 Missing and 1 partial ⚠️
internal/cmd/floatingip/describe.go 50.00% 2 Missing and 1 partial ⚠️
internal/cmd/image/describe.go 50.00% 2 Missing and 1 partial ⚠️
internal/cmd/iso/describe.go 50.00% 2 Missing and 1 partial ⚠️
internal/cmd/loadbalancer/describe.go 50.00% 2 Missing and 1 partial ⚠️
internal/cmd/loadbalancertype/describe.go 50.00% 2 Missing and 1 partial ⚠️
internal/cmd/location/describe.go 50.00% 2 Missing and 1 partial ⚠️
internal/cmd/network/describe.go 50.00% 2 Missing and 1 partial ⚠️
... and 6 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #650      +/-   ##
==========================================
- Coverage   46.23%   45.94%   -0.29%     
==========================================
  Files         171      171              
  Lines        7468     7517      +49     
==========================================
+ Hits         3453     3454       +1     
- Misses       3591     3623      +32     
- Partials      424      440      +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jooola
jooola requested changes Dec 19, 2023
View reviewed changes
internal/cmd/base/describe.go Outdated Show resolved Hide resolved
@jooola jooola changed the title fix: integer fields are displayed as floats when using describe with -o=yaml fix: integer fields are displayed as floats when using described with -o=yaml Dec 19, 2023
@jooola jooola changed the title fix: integer fields are displayed as floats when using described with -o=yaml fix: integer fields are displayed as floats when using describe with -o=yaml Dec 19, 2023
@phm07 phm07 merged commit ee4c51e into main Dec 19, 2023
3 checks passed
@phm07 phm07 deleted the fix-describe-schema branch December 19, 2023 10:48
@hcloud-bot hcloud-bot mentioned this pull request Dec 19, 2023
Closed
@phm07 phm07 mentioned this pull request Dec 19, 2023
Merged
phm07 added a commit that referenced this pull request Dec 20, 2023
@phm07 @jooola
fix: integer fields are displayed as floats when using create with o=…
2d42fcd 
…yaml (#651)

Continuation #650, closes #638

When outputting a resource after creation, it is first converted into a
schema struct. This fixes bugs like #638 and also makes all schema
outputs (describe, list, create) consistent.

---------

Co-authored-by: jo <ljonas@riseup.net>
@hcloud-bot hcloud-bot mentioned this pull request Dec 20, 2023
Merged
jooola pushed a commit that referenced this pull request Dec 21, 2023
@hcloud-bot
chore(main): release 1.41.1 (#652)
468ef81 
🤖 I have created a release *beep* *boop*
---


##
[1.41.1](v1.41.0...v1.41.1)
(2023-12-21)


### Bug Fixes

* allow multiple --type flags for metrics commands
([#649](#649))
([69346f7](69346f7)),
closes [#642](#642)
* integer fields are displayed as floats when using create with o=yaml
([#651](#651))
([2d42fcd](2d42fcd))
* integer fields are displayed as floats when using describe with
-o=yaml ([#650](#650))
([ee4c51e](ee4c51e)),
closes [#638](#638)
* wording when metrics are not yet available
([#639](#639))
([9298c46](9298c46))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@BrewTestBot BrewTestBot mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jooola jooola jooola approved these changes

Assignees

@phm07 phm07

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: integer fields are displayed as floats when using describe with o=yaml
2 participants
@phm07 @jooola