fix: integer fields are displayed as floats when using create with o=yaml #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phm07
force-pushed
the
fix-yaml-output
branch
from
e0abef5
to
1d2f775
Compare
|
The json output for the create commands has already been released with 1.40.0, I think its a bit late to introduce a breaking change. Could we use a workaround to wrap the schema? Maybe using inline structs ? |
|
Yeah, I'll add that |
phm07
force-pushed
the
fix-yaml-output
branch
from
1d2f775
to
bf40c7c
Compare
phm07
force-pushed
the
fix-yaml-output
branch
from
bf40c7c
to
9b21c3f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
==========================================
+ Coverage 45.94% 45.98% +0.03%
==========================================
Files 171 171
Lines 7517 7514 -3
==========================================
+ Hits 3454 3455 +1
+ Misses 3623 3616 -7
- Partials 440 443 +3 ☔ View full report in Codecov by Sentry. |
phm07
force-pushed
the
fix-yaml-output
branch
from
191764c
to
52a9b08
Compare
jooola
approved these changes
Dec 20, 2023
|
🚀 |
jooola
pushed a commit
that referenced
this pull request
Dec 21, 2023
🤖 I have created a release *beep* *boop* --- ## [1.41.1](v1.41.0...v1.41.1) (2023-12-21) ### Bug Fixes * allow multiple --type flags for metrics commands ([#649](#649)) ([69346f7](69346f7)), closes [#642](#642) * integer fields are displayed as floats when using create with o=yaml ([#651](#651)) ([2d42fcd](2d42fcd)) * integer fields are displayed as floats when using describe with -o=yaml ([#650](#650)) ([ee4c51e](ee4c51e)), closes [#638](#638) * wording when metrics are not yet available ([#639](#639)) ([9298c46](9298c46)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation #650, closes #638
When outputting a resource after creation, it is first converted into a schema struct. This fixes bugs like #638 and also makes all schema outputs (describe, list, create) consistent.