Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow adding/removing multiple labels at once #665

Merged
merged 1 commit into from
Jan 9, 2024
Merged

feat: allow adding/removing multiple labels at once #665

merged 1 commit into from
Jan 9, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Jan 9, 2024

Closes #662

@phm07 phm07 added the feature label Jan 9, 2024
@phm07 phm07 self-assigned this Jan 9, 2024
@phm07 phm07 requested a review from a team as a code owner January 9, 2024 09:06
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1bd800) 45.98% compared to head (6d688a4) 45.98%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #665   +/-   ##
=======================================
  Coverage   45.98%   45.98%           
=======================================
  Files         171      171           
  Lines        7514     7514           
=======================================
  Hits         3455     3455           
  Misses       3616     3616           
  Partials      443      443

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola
Copy link
Member

jooola commented Jan 9, 2024

The validateAddLabel and validateRemoveLabel functions might need updating too.

@phm07
Copy link
Contributor Author

phm07 commented Jan 9, 2024

I updated validateAddLabel to account for the new changes

apricote
apricote approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@apricote apricote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works great :)

@phm07 phm07 merged commit 919c446 into main Jan 9, 2024
3 checks passed
@phm07 phm07 deleted the label-cmds branch January 9, 2024 10:56
@hcloud-bot hcloud-bot mentioned this pull request Jan 9, 2024
Merged
apricote pushed a commit that referenced this pull request Feb 1, 2024
@hcloud-bot
chore(main): release 1.42.0 (#664)
08338de 
## [1.42.0](v1.41.1...v1.42.0) (2024-02-01)


### Features

* add global --quiet flag to hide non-error messages
([#656](#656))
([25fcbbf](25fcbbf)),
closes [#644](#644)
* allow adding/removing multiple labels at once
([#665](#665))
([919c446](919c446)),
closes [#662](#662)
* group subcommands in command help
([#675](#675))
([0cb271f](0cb271f))
* **server:** remove unsupported linux32 rescue type
([#679](#679))
([5bb0350](5bb0350))


### Bug Fixes

* refetch after creating managed certificate
([#685](#685))
([4864553](4864553))
* **server:** fix typo in ip subcommand
([#678](#678))
([c5e3f00](c5e3f00))
* use --poll-interval flag
([#660](#660))
([b9328a6](b9328a6))
@BrewTestBot BrewTestBot mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apricote apricote apricote approved these changes

Assignees

@phm07 phm07

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow adding/removing multiple labels at once
3 participants
@phm07 @jooola @apricote