feat: allow deletion of multiple resources at once #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
==========================================
- Coverage 58.44% 58.43% -0.02%
==========================================
Files 180 180
Lines 6507 6510 +3
==========================================
+ Hits 3803 3804 +1
- Misses 2094 2096 +2
Partials 610 610 ☔ View full report in Codecov by Sentry. |
apricote
reviewed
Mar 25, 2024
apricote
approved these changes
Apr 3, 2024
| if err != nil { | ||
| return err | ||
| } | ||
| for _, idOrName := range args { |
There was a problem hiding this comment.
The current code deletes the resources in series. Doing it in parallel would be faster and we could wait for all actions at once.
I am fine with merging it as it is and leaving this for the future to optimize.
There was a problem hiding this comment.
Doing it this way we can guarantee the order of operations (which is also important for the tests for example). I agree that we can leave it like this for now.
phm07
pushed a commit
that referenced
this pull request
Apr 3, 2024
🤖 I have created a release *beep* *boop* --- ## [1.43.0](v1.42.0...v1.43.0) (2024-04-03) ### Features * allow deletion of multiple resources at once ([#719](#719)) ([3b896fe](3b896fe)) * improve missing argument error messages ([#711](#711)) ([e7f9e74](e7f9e74)) * **server:** allow JSON & YAML output in reset-password ([#716](#716)) ([373287b](373287b)), closes [#715](#715) ### Bug Fixes * removing last rule from firewall fails with invalid_input error ([#696](#696)) ([acab17c](acab17c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
phm07
added a commit
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the CLI only allows you to delete one resource at a time. This can be time consuming and tedious if you want to delete multiple resources, because you have to wait for each resource to be deleted before you can delete the next one.
This PR adds the ability to delete multiple resources at once by passing them to the
deletesubcommand as multiple positional arguments, e.g.hcloud server delete server1 server2 .... It also adds tests to verify that this works as intended.