Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: btrfs volumes can not be formatted #421

Closed
apricote opened this issue Jun 16, 2023 · 3 comments
Closed

fix: btrfs volumes can not be formatted #421

apricote opened this issue Jun 16, 2023 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@apricote
Copy link
Member

We support btrfs volumes since #200, but it looks like the formatting was not added in #279 when we changed the way volumes are formatted.

We need to add a case for formatting btrfs volumes here and to the e2e test configuration to make sure that it actually works and we do not accidentally break it in the future.

Originally posted by @felixscheinost in #200 (comment)
@felixscheinost
Copy link
Contributor

Thank you for opening the issue! I'm curious to see what the e2e tests say. Could be that this is an easy fix, right?

@apricote
Copy link
Member Author

Yea, btrs-progs are already installed, so adding it back in should be ~3 lines and a quick sanity check that it actually works.

@apricote apricote added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jun 19, 2023
felixscheinost added a commit to symentis/hcloud-csi-driver that referenced this issue Jun 21, 2023
@felixscheinost
fix: btrfs volumes can not be formatted (hetznercloud#421)
11d8588
apricote pushed a commit that referenced this issue Jun 28, 2023
@felixscheinost
fix: btrfs volumes can not be formatted (#421) (#424)
be3fbc9
@apricote
Copy link
Member Author

Fixed in #424

@hcloud-bot hcloud-bot mentioned this issue Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apricote @felixscheinost