Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement topology awareness #11

Merged
merged 3 commits into from
Feb 7, 2019
Merged

Implement topology awareness #11

merged 3 commits into from
Feb 7, 2019

Conversation

thcyron
Copy link
Contributor

@thcyron thcyron commented Feb 5, 2019

Fixes #10.

Todo

  • Update storageclass manifest (WaitForFirstConsumer)
  • Update readme to enable feature gates for CSINoteInfo, etc.
  • Update readme to create CSINoteInfo CRD

@thcyron
Copy link
Contributor Author

thcyron commented Feb 5, 2019

I pushed hetznercloud/hcloud-csi-driver:1.1.0-rc.1 to Docker Hub with that change. Hope to be able to test that on a real cluster today before merging.

cc @mcadam

@thcyron thcyron merged commit e47ed5e into master Feb 7, 2019
@thcyron thcyron deleted the topology branch February 7, 2019 14:10
@deacix
Copy link

deacix commented Apr 16, 2019

How to use it? It's not working out of box. My volumes are deployed in the same location where the controller is running...

@bascht
Copy link

bascht commented Jul 23, 2019

Same here – running 1.14 and the version from master @ https://raw.githubusercontent.com/hetznercloud/csi-driver/master/deploy/kubernetes/hcloud-csi.yml and all volumes are deployed in the same location as the controller like in @deacix case.

@thcyron is there a way to debug this or supply any helpful information?

@thcyron
Copy link
Contributor Author

thcyron commented Jul 23, 2019

To check if topology awareness is working:

  1. Create a pod and schedule it on a node in a specific location
  2. Create and attach a volume to that pod
  3. Verify that the volume has been created in that location

Do this for every location you have nodes in. If pod creation failed, please provide the error messages.

@bascht
Copy link

bascht commented Jul 23, 2019

@thcyron Alright – I think I'm onto something. See #42. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volume in different location than Pod
4 participants