Build the Docker image on any platform #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been marked as stale because it has not had recent activity. The bot will close the PR if no further action occurs. |
hakman
force-pushed
the
build_on_other_platforms
branch
from
ef80bc6
to
5abf85e
Compare
|
@apricote Was wondering if this approach if of any use in general. |
Thanks for the contribution! It certainly is in my opinion, we should make sure that anyone can contribute to the project, whether they use ARM or x86_64. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resulting Docker image should have the same platform, no matter where it's built.
This change will make sure both the binaries and the base image are always
linux/amd64.I also updated the Alpline Linux image to 3.16, as 3.13 is approaching end of support.