Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Block volumes are formatted #349 #353

Merged
merged 2 commits into from
Jan 13, 2023
Merged

fix: Block volumes are formatted #349 #353

merged 2 commits into from
Jan 13, 2023

Conversation

apricote
Copy link
Member

A recently introduced change (#279) caused block volumes to be formatted with ext4. This happened because setting the default for the FS type was moved from the non-Block Volume branch into the general code.

This PR reverts the move and adds a test to make sure that block storage is not accidentally formatted again in the future.

A recently introduced change caused block volumes to be formatted with
ext4. This happened because setting the default for the FS type was
moved from the non-Block Volume branch into the general code.
@apricote apricote added the bug Something isn't working label Jan 12, 2023
@apricote apricote self-assigned this Jan 12, 2023
@apricote apricote merged commit e79755f into main Jan 13, 2023
@apricote apricote deleted the fix-volume-formatting branch January 13, 2023 09:28
@toabi toabi mentioned this pull request Jan 20, 2023
@toabi
Copy link

toabi commented Jan 20, 2023

@apricote is there a date planned for releasing this fix?

@apricote
Copy link
Member Author

@apricote is there a date planned for releasing this fix?

I plan on releasing a new version today.

@toabi
Copy link

toabi commented Jan 23, 2023

@apricote tried it and it is indeed fixed, just manual deletion of volumeattachments is sometimes necessary.

By the way, I noticed the README was not updated with links to the latest version.

@apricote
Copy link
Member Author

@apricote tried it and it is indeed fixed, just manual deletion of volumeattachments is sometimes necessary.

This might be related to the second issue described here #278 (comment), check if this matches your experience. If it is different, please open a new issue.

By the way, I noticed the README was not updated with links to the latest version.

I should get around to automate this.. Thanks for notifying, opened #367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants