feat: set allow discards on luksOpen #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default Hetzner Cloud uses thin provisioning for Volumes. This way, only the space that is actually used by the customer needs to be allocated in the storage pools. Encrypting the volumes using LUKS breaks this thin provisioning, and the full amount needs to be allocated. By setting allow-discards when mounting the volume, we tell the driver to use TRIM/discard, which re-enables the thin-provisioning for the volume. This can be done when creating the LUKS partition, or when mounting it. By doing it on the mount, this will also be enabled for volumes that already exist prior to this commit when they are being re-attach anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default Hetzner Cloud uses thin provisioning for Volumes. This way, only the space that is actually used by the customer needs to be allocated in the storage pools.
Encrypting the volumes using LUKS breaks this thin provisioning, and the full amount needs to be allocated.
By setting allow-discards when mounting the volume, we tell the driver to use TRIM/discard, which re-enables the thin-provisioning for the volume.
This can be done when creating the LUKS partition, or when mounting it. By doing it on the mount, this will also be enabled for volumes that already exist prior to this commit when they are being re-attach anyway.