Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Port & Review Changes from Syself fork #525

Closed
Tracked by #523
apricote opened this issue Oct 4, 2023 · 0 comments · Fixed by #561
Closed
Tracked by #523

feat: Port & Review Changes from Syself fork #525

apricote opened this issue Oct 4, 2023 · 0 comments · Fixed by #561
Assignees
@apricote

Comments

@apricote
Copy link
Member

apricote commented Oct 4, 2023 •
edited

Cherry-pick the relevant commits from the syself fork & make them work against current main.

Commits: main...syself:hetzner-cloud-controller-manager:main
@apricote apricote mentioned this issue Oct 4, 2023
Closed
4 tasks
@apricote apricote changed the title Port & Review Syself Changes feat: Port & Review Changes from Syself fork Oct 4, 2023
@apricote apricote self-assigned this Oct 4, 2023
@apricote apricote mentioned this issue Oct 25, 2023
Merged
@apricote apricote mentioned this issue Nov 8, 2023
Merged
apricote added a commit that referenced this issue Nov 8, 2023
@apricote
refactor: use full cfg in lbops (#557)
ce2004c 
This will be required for Robot support, as the LBOps code will need to
know wether Robot support is enabled or not.

Related to #525 #549
@apricote apricote mentioned this issue Nov 13, 2023
Merged
apricote added a commit that referenced this issue Nov 21, 2023
@apricote @janiskemper
@DENKweit @guettli @kranurag7 @batistein
feat: support for Robot servers (#561)
65dea11 
Based on the Fork by Syself[0] and the Design Doc[1].

[0] https://github.com/syself/hetzner-cloud-controller-manager
[1] #523 (comment)

This ports most features of the fork while refactoring them to match
our coding style and the improvements I made in preparation for this.

Closes #525 #526 #527

---------

Co-authored-by: janiskemper <janis.kemper@syself.com>
Co-authored-by: Mawe Sprenger <mawe.sprenger@denkweit.de>
Co-authored-by: Thomas Guettler <thomas.guettler@syself.com>
Co-authored-by: Anurag <contact.anurag7@gmail.com>
Co-authored-by: batistein <sven.batista-steinbach@syself.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apricote apricote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support for Robot servers hetznercloud/hcloud-cloud-controller-manager
1 participant
@apricote