Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use new client.Action.WaitFor #171

Closed
wants to merge 2 commits into from
Closed

Conversation

jooola
Copy link
Member

@jooola jooola commented Apr 30, 2024

This use the new client.Action.WaitFor API for waiting actions.

@jooola jooola force-pushed the use-action-waiter branch 2 times, most recently from 04296d7 to 046a694 Compare April 30, 2024 14:01
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 29.48%. Comparing base (c97ceee) to head (8917e52).

Files Patch % Lines
builder/hcloud/step_create_server.go 0.00% 7 Missing and 2 partials ⚠️
builder/hcloud/step_shutdown_server.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   29.51%   29.48%   -0.03%     
==========================================
  Files          11       11              
  Lines         654      641      -13     
==========================================
- Hits          193      189       -4     
+ Misses        436      428       -8     
+ Partials       25       24       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola
Copy link
Member Author

jooola commented May 6, 2024

Part of #176

@jooola jooola closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants