feat: allow disabling the server public ips #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
==========================================
- Coverage 32.49% 32.11% -0.38%
==========================================
Files 11 11
Lines 677 685 +8
==========================================
Hits 220 220
- Misses 433 441 +8
Partials 24 24 ☔ View full report in Codecov by Sentry. |
jooola
force-pushed
the
disable-public-ips
branch
from
45db657
to
d64888d
Compare
jooola
force-pushed
the
disable-public-ips
branch
from
d64888d
to
c78ea15
Compare
apricote
requested changes
Jun 5, 2024
apricote
approved these changes
Jun 5, 2024
jooola
pushed a commit
that referenced
this pull request
Jun 5, 2024
🤖 I have created a release *beep* *boop* --- ## [1.5.0](v1.4.0...v1.5.0) (2024-06-05) ### Features * add HCP packer support ([#122](#122)) ([85435ef](85435ef)) * allow disabling the server public ips ([#190](#190)) ([82e6cdb](82e6cdb)), closes [#188](#188) ### Bug Fixes * ensure the upgrade server type is not nil ([#182](#182)) ([d297dcb](d297dcb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow disabling the server's public IPs, and use the first available IP to connect to it (IPv4, IPv6, first private network IP).
Closes #188