Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add HCP Packer support #91

Closed
wants to merge 0 commits into from

Conversation

ajax-ryzhyi-r
Copy link
Contributor

This pull request adds support for the HCP Packer registry by including the necessary metadata in the image state.
For more details see: https://developer.hashicorp.com/packer/docs/plugins/creation/hcp-support

@ajax-ryzhyi-r ajax-ryzhyi-r requested a review from a team as a code owner October 20, 2023 13:34
@hashicorp-cla
Copy link

hashicorp-cla commented Oct 20, 2023

CLA assistant check
All committers have signed the CLA.

@nywilken
Copy link
Contributor

Hi @ajax-ryzhyi-r thanks for adding HCP Packer support to this plugin. The initial implementation is off to a good start but there are a few missing pieces of metadata like the source image id, used for ancestry tracking, and region data. Here's an example of all the information needed for a complete integration Linode HCP Support

We are starting the process of transferring this plugin to the Hetzner Cloud team so further reviews from may be delayed until the transfer has completed.

@ajax-ryzhyi-r
Copy link
Contributor Author

Hi @ajax-ryzhyi-r thanks for adding HCP Packer support to this plugin. The initial implementation is off to a good start but there are a few missing pieces of metadata like the source image id, used for ancestry tracking, and region data. Here's an example of all the information needed for a complete integration Linode HCP Support

We are starting the process of transferring this plugin to the Hetzner Cloud team so further reviews from may be delayed until the transfer has completed.

Thank you for the review! I'll add the missing pieces a little bit later 🙂

@jooola
Copy link
Member

jooola commented Nov 13, 2023

@ajax-ryzhyi-r Hey, thanks a lot for the contributions!

I accidentally closed your PR while rebasing your branch ☕ and testing it locally. Sadly, I cannot reopen your PR. I recovered your changes and pushed them here https://github.com/hetznercloud/packer-plugin-hcloud/tree/ajax-ryzhyi-r/main

Could you reopen the PR, please? I can also open another PR with your changes, if you are ok with this?

@jooola jooola self-assigned this Nov 13, 2023
jooola added a commit that referenced this pull request Jun 4, 2024
This pull request adds support for the HCP Packer registry by including
the necessary metadata in the image state.

For more details, see:
https://developer.hashicorp.com/packer/docs/plugins/creation/hcp-support

Continuation of #91 after accidentally closing the PR.

---------

Co-authored-by: Roman Ryzhyi <ryzhyi.r@ajax.systems>
Co-authored-by: Julian Tölle <julian.toelle@hetzner-cloud.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants