Add sample for label selector to the documentation #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
galexrt
reviewed
Sep 17, 2018
website/docs/d/image.html.md
Outdated
| @@ -24,6 +27,8 @@ resource "hcloud_server" "main" { | |||
| ## Argument Reference | |||
| - `id` - (Optional, string) ID of the Image. | |||
| - `name` - (Optional, string) Name of the Image. | |||
| - `selector` - (Optional, string) Label selector for the [label selector](https://docs.hetzner.cloud/#overview-label-selector). | |||
|
|
|||
There was a problem hiding this comment.
I personally would leave only one empty line as the other sections have it. :-)
thcyron
reviewed
Sep 17, 2018
website/docs/d/image.html.md
Outdated
| @@ -24,6 +27,8 @@ resource "hcloud_server" "main" { | |||
| ## Argument Reference | |||
| - `id` - (Optional, string) ID of the Image. | |||
| - `name` - (Optional, string) Name of the Image. | |||
| - `selector` - (Optional, string) Label selector for the [label selector](https://docs.hetzner.cloud/#overview-label-selector). | |||
|
|
|||
There was a problem hiding this comment.
“Label selector for the label selector” sounds odd.
Only linking our documentation page.
thcyron
approved these changes
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some samples for the label selector to the data source documentations.
@thcyron
Can you review this?