fix: error when deleting hcloud_primary_ip with auto_delete #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error sometimes happened if the primary_ip was deleted faster in the API than in Terraform. This sometimes caused a flaky e2e test `TestPrimaryIPResource_with_server`, and was excerbarated by the recent changes made to the server delete code, where we now wait for the IP to report that is is not assigned, before allowing any further resource deletions.
LKaemmerling
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error sometimes happened if the
primary_ipwas deleted faster in the API (through auto deletion when the server was deleted) than in Terraform.This caused a flaky e2e test
TestPrimaryIPResource_with_serveras well as the issue described in #579 (comment).