Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test TestServerResource_PrimaryIPNetworkTests #587

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

apricote
Copy link
Member

@apricote apricote commented Nov 8, 2022

Test was flaky because two hcloud_primary_ip resources used the same name, but name must be unique. Fixed using different names.

Error message:

resource_test.go:520: Step 6/7 error: Error running apply: exit status 1

Error: name is already used (uniqueness_error)

  with hcloud_primary_ip.primary-ip-v6,
  on terraform_plugin_test.tf line 21, in resource "hcloud_primary_ip" "primary-ip-v6":
  21: resource "hcloud_primary_ip" "primary-ip-v6" {

--- FAIL: TestServerResource_PrimaryIPNetworkTests (123.13s)

Test was flaky because two hcloud_primary_ip resources used the same name,
but name must be unique. Fixed using different names.

Error message:

    resource_test.go:520: Step 6/7 error: Error running apply: exit status 1

    Error: name is already used (uniqueness_error)

      with hcloud_primary_ip.primary-ip-v6,
      on terraform_plugin_test.tf line 21, in resource "hcloud_primary_ip" "primary-ip-v6":
      21: resource "hcloud_primary_ip" "primary-ip-v6" {

    --- FAIL: TestServerResource_PrimaryIPNetworkTests (123.13s)
@apricote apricote added the bug label Nov 8, 2022
@apricote apricote self-assigned this Nov 8, 2022
@apricote apricote merged commit 2ce05a1 into main Nov 8, 2022
@apricote apricote deleted the flake-primaryip-name branch November 8, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants