fix: race-condition when re-creating server with external primary ip #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When re-creating a server with a primary ip, the replacement server creation failed due to a race condition: - initial server is deleted through terraform - API responds to server deletion - Primary IP is still marked as "attached" in API due to async internal process - Terraform tries to create new server - API call fails because primary API is still marked as "attached" and can not be used for new server By waiting until the returned action from server delete is completed, we can fix this race condition. Reported on GitHub: #558
LKaemmerling
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When re-creating a server with a primary ip, the replacement server creation failed due to a race condition:
By waiting until the returned action from server delete is completed, we can fix this race condition.
Closes #558