fix(server): unnecessary updates when using network #556 #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the `network` parameter of `hcloud_server` resource, the plan would always contain a diff, because the field `alias_ip` is not set by the user, but has a value in the plan. The field is automatically set to an empty set by the API -> it is computed and should be marked as such. Fixes #556
LKaemmerling
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
networkparameter ofhcloud_serverresource, the plan would always contain a diff, because the fieldalias_ipis not set by the user, but has a value in the plan. The field is automatically set to an empty set by the API -> it is computed and should be marked as such.Fixes #556