Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find_version should operate with bits and not with modes #26

Closed
heuer opened this issue Sep 21, 2016 · 0 comments
Closed

find_version should operate with bits and not with modes #26

heuer opened this issue Sep 21, 2016 · 0 comments
Labels
bug
Milestone
0.2.2

Comments

@heuer
Copy link
Owner

heuer commented Sep 21, 2016 •
edited
Loading

encoder.find_version takes the character count (len(data)) and the individual modes into account. This may lead to suboptimal versions. find_version should take the number of bits into account. Further, it should take the overhead (mode indicator, length of char indicator) into account, see TODO.
@heuer heuer added this to the 0.2.2 milestone Sep 21, 2016
@heuer heuer added the bug label Sep 21, 2016
@heuer heuer closed this as completed in ac0e39e Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.2.2
Development

No branches or pull requests
1 participant
@heuer