Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creation of Micro QR Code leaves areas undefined #3

Closed
heuer opened this issue Aug 16, 2016 · 3 comments
Closed

Creation of Micro QR Code leaves areas undefined #3

heuer opened this issue Aug 16, 2016 · 3 comments
Labels
bug
Milestone
0.1.2

Comments

@heuer
Copy link
Owner

heuer commented Aug 16, 2016 

>>> import segno
>>> from segno import writers
>>> qr = segno.make('test')
>>> qr.designator
'M3-M'
>>> qr.mask
3
>>> writers.write_svg_debug(qr.matrix, qr._version, 'issue-3.svg')
@heuer
Copy link
Owner Author

heuer commented Aug 16, 2016 •
edited
Loading

bug-3

heuer added a commit that referenced this issue Aug 16, 2016
@heuer
Added test cases for issue #3
23887ea
@heuer heuer added the bug label Aug 16, 2016
@heuer
Copy link
Owner Author

heuer commented Aug 16, 2016

Matrix after placing final message codewords
bug-3-codewords

@heuer
Copy link
Owner Author

heuer commented Aug 16, 2016 •
edited
Loading

Reason: Not enough padding / terminator / remainder bits (M1 - M4 dont' have remainder bits)

@heuer heuer added this to the 0.1.2 milestone Aug 16, 2016
heuer added a commit that referenced this issue Aug 17, 2016
@heuer
* Wrong calc of number of pad codewords. Fixes issue #3
59757c8 
* encode(..., error='m', ...) would not create a M1 Code, changed to error=None. Fixes issue #4
@heuer heuer closed this as completed Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.1.2
Development

No branches or pull requests
1 participant
@heuer