two TODO task completed in GenericTest.kt #428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaguililla
reviewed
Oct 2, 2021
| @@ -78,7 +78,7 @@ internal class XmlTest { | |||
| } | |||
|
|
|||
| @Test | |||
| @Disabled // TODO Fix this case | |||
There was a problem hiding this comment.
Does this test pass once enabled? This test was disabled because it wasn't working and it should, so some changes on the XML module should be made to make it pass ;)
The true goal of this TODO was to enable the test again... and make it pass, did you check it?
jaguililla
reviewed
Oct 2, 2021
| @@ -33,7 +33,7 @@ data class TestResponse( | |||
|
|
|||
| override fun redirect(url: String) { | |||
| status = 301 | |||
| // setHeader("location", url) // TODO Fix this | |||
There was a problem hiding this comment.
The TODO intended action is to add the "location" header to the TestResponse instance. That is, uncommenting that line and assuring it is set (if there is no test to assure that, it should be created).
|
Please, don't forget to file PRs to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two TODO task completed in GenericTest.kt
#369