Skip to content
This repository has been archived by the owner on Feb 10, 2024. It is now read-only.

generates extremely long JOIN commands on reconnect #1929

Open
pabs3 opened this issue Jan 8, 2017 · 1 comment
Open

generates extremely long JOIN commands on reconnect #1929

pabs3 opened this issue Jan 8, 2017 · 1 comment
Labels

Comments

@pabs3
Copy link
Member

pabs3 commented Jan 8, 2017

I am in a lot of channels on one particular server (including one channel with a key) and when reconnecting, hexchat generates a 539-character JOIN command (including JOIN, the comma-separated list of channels and comma-separated list of keys, with 'x' as the key for channels with no key). Consequently, the command gets cut off somewhere in the list of keys and hexchat does not rejoin the channel because the server says "Cannot join channel (+k)". I think the truncation happens server-side because the JOIN command in the raw log isn't truncated within the key of the affected channel.

Removing the 'x' characters for non-keyworded channels would reduce the size, but it my case it doesn't reduce it enough to make rejoins on reconnects work. I still think this should be done, there is no reason to put x in the keywords of the JOIN command AFAIK.

Splitting up the JOIN command generated on RECONNECT into relatively small lengths is the correct solution to this issue.

@TingPing TingPing added the bug label Jan 8, 2017
@TingPing
Copy link
Member

TingPing commented Jan 8, 2017

Removing the 'x' characters for non-keyworded channels would reduce the size, but it my case it doesn't reduce it enough to make rejoins on reconnects work. I still think this should be done, there is no reason to put x in the keywords of the JOIN command AFAIK.

This logic predates hexchat but the comments were that some networks could not handle empty keys so some character has to be there. I believe I verified that behavior is still relevant at some point so I don't think it should be removed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

2 participants