This repository has been archived by the owner on Feb 10, 2024. It is now read-only.
fe-gtk: notification_plugin_deinit type mismatch #2726
Comments
NexAdn
added a commit
to NexAdn/hexchat
that referenced
this issue
Aug 21, 2022
Previously the function signature was inconsistent throughout
src/fe-gtk/plugin-notification.{h,c}: One file had the signature
int(void), while the other had int(void*). Since this type mismatch
might lead to problems (especially with LTO) and the (possibly provided)
function argument isn't used in the function's definition, this commit
sets int(void) as function signature for both the declaration and
definition of the function.
Fixes: hexchat#2726
NexAdn
added a commit
to NexAdn/gentoo
that referenced
this issue
Aug 21, 2022
Workaround for LTO type mismatch issue until upstream applies the fix for this issue [1]. [1] hexchat/hexchat#2726 Closes: https://bugs.gentoo.org/861458 Signed-off-by: Adrian Schollmeyer <nex+b-g-o@nexadn.de>
NexAdn
added a commit
to NexAdn/gentoo
that referenced
this issue
Aug 21, 2022
Workaround for LTO type mismatch issue until upstream applies the fix for this issue [1]. [1] hexchat/hexchat#2726 Closes: https://bugs.gentoo.org/861458 Signed-off-by: Adrian Schollmeyer <nex+b-g-o@nexadn.de>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this issue
Aug 23, 2022
Workaround for LTO type mismatch issue until upstream applies the fix for this issue [1]. [1] hexchat/hexchat#2726 Closes: https://bugs.gentoo.org/861458 Signed-off-by: Adrian Schollmeyer <nex+b-g-o@nexadn.de> Closes: #26949 Signed-off-by: Sam James <sam@gentoo.org>
NexAdn
added a commit
to NexAdn/hexchat
that referenced
this issue
Aug 26, 2022
Previously the function signature was inconsistent throughout
src/fe-gtk/plugin-notification.{h,c}: One file had the signature
int(void), while the other had int(void *). Since this type mismatch
might lead to problems (especially with LTO) and the (possibly provided)
function argument isn't used in the function's definition, this commit
sets int(void *) as function signature for both the declaration and
definition of the function.
Fixes: hexchat#2726
NexAdn
added a commit
to NexAdn/hexchat
that referenced
this issue
Aug 26, 2022
Previously the function signature was inconsistent throughout
src/fe-gtk/plugin-notification.{h,c}: One file had the signature
int(void), while the other had int(void *). Since this type mismatch
might lead to problems (especially with LTO) and the (possibly provided)
function argument isn't used in the function's definition, this commit
sets int(void *) as function signature for both the declaration and
definition of the function.
Fixes: hexchat#2726
TingPing
pushed a commit
that referenced
this issue
Aug 26, 2022
Previously the function signature was inconsistent throughout
src/fe-gtk/plugin-notification.{h,c}: One file had the signature
int(void), while the other had int(void *). Since this type mismatch
might lead to problems (especially with LTO) and the (possibly provided)
function argument isn't used in the function's definition, this commit
sets int(void *) as function signature for both the declaration and
definition of the function.
Fixes: #2726
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The function
int notification_plugin_deinit()has two differing function signatures,resulting in a type mismatch.
Version 1 (header file):
hexchat/src/fe-gtk/plugin-notification.h
Line 23 in d7c6c42
Version 2 (source file):
hexchat/src/fe-gtk/plugin-notification.c
Lines 248 to 250 in d7c6c42
Original build output: https://861458.bugs.gentoo.org/attachment.cgi?id=794948
Since the function does not use a hypothetical function argument, it's probably safe to use
int(void)has function signature.To reproduce locally, just build with
CFLAGS="-flto -Werror=lto-type-mismatch"andmeson -Dplugin=trueThe text was updated successfully, but these errors were encountered: