Skip to content
This repository has been archived by the owner on Feb 10, 2024. It is now read-only.

Socks 5 username and password length #1994

Closed
wants to merge 2 commits into from
Closed

Conversation

kelek-
Copy link

@kelek- kelek- commented Apr 22, 2017

Updated the maximum length of the socks5 user and password to comply to RFC 1929, where both the password and the username length is definied as a maximum of 255

…to RFC 1929, where both the password and the username length is definied as a maximum of 255
Copy link
Member

@TingPing TingPing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has implications elsewhere, for example in server.c this string is copied into a buffer that is only size 260 itself.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

2 participants