Skip to content
This repository has been archived by the owner on Feb 10, 2024. It is now read-only.

Avoid using ELLIPSIS macro #2316

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid using ELLIPSIS macro #2316

wants to merge 1 commit into from

Conversation

lsahn-gh
Copy link

Some strings using the macro cannot be translated in the right way,
because PO files are made by source code instead of compile-time code.
The macro is actually translated while compilation and therefore it
causes the issue, #2275.

To fix the issue, use the literal ellipsis string instead of it.

Fixes #2275

@TingPing
Copy link
Member

The reason this was done in the first place is msvc doesn't like non-ascii text.

Some strings using the macro cannot be translated in the right way,
because PO files are made by source code instead of compile-time code.
The macro is actually translated while compilation and therefore it
causes the issue, #2275.

To fix the issue, use UTF-8 hex code instead of it.

Fixes #2275
@lsahn-gh
Copy link
Author

I changed it to use ellipsis utf-8 hex code itself in the messages. This is probably a solution for windows too. Another solution is to use three dots there.

@TingPing
Copy link
Member

I guess that works, it doesn't help the situation for translators though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Some strings cannot be translated
2 participants